Enable Gateway to Request Cache Asynchronously - #756
Conversation
|
I don't think you need this PR too, you can combine them into one here You can also remove the file from this PR where you just have some placeholder code |
|
Hi Cormac, I have combined the "Enable Gateway to Read Cache" and "Enable Gateway to Request Cache Asynchronously" PRs into one PR here. I have also removed the getter.q file containing placeholder code from the "Add cacheConfig, setter process, getter script" PR. I have also addressed your other comments. |
|
Hi Cormac, thank you for reviewing and your comments. I have uploaded a template cacheconfig.json file containing configurations for the Anycache system. The cachename and asyncprocessname is now part of the cacheconfig.json file so there is no need to pass them as parameters to functions. |
| getcachefromdisk:{[filepath] get hsym filepath} | ||
|
|
||
| // Get location of cache config and load it in. | ||
| cacheconfiglocation:.proc.getconfigfile["cacheconfig.json"]; |
There was a problem hiding this comment.
This should probably be a function of some sort - takes a config filename, if empty load the default
| { | ||
| "cacherootdir": "opt/anycache", | ||
| "cachename": "MyFirstCache", | ||
| "asyncprocessname": "AsyncCache", |
There was a problem hiding this comment.
CamelCase - check other config files in TorQ, if they use CamelCase it's okay but if not then change to match the convention
|
We also need to have some detailed notes, documentation and testing proof in this PR and any other related PRs (this goes for any new features that are being added to TorQ). This can be added in a README.md file in the root directory of the AnyCache component |
| @@ -0,0 +1,28 @@ | |||
| // Bootstrap script that will enable an existing process to load in cache getter functionalities. | |||
|
|
|||
| \d .getter | |||
Enable Gateway to Request Cache Asynchonously as per Phase 3.1 of Anycache Project Plan.